PCR 10093 - results of oversight reviews
Summary: results of oversight reviews
Status: ASSIGNED
Alias: None
Product: Kernel
Classification: Deos
Component: Kernel (show other PCRs)
Version: 7.10.6
Hardware: All Deos
: By Cert
: Enhancement
Target Milestone: mainline
Assignee: .Kernel
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2015-09-03 05:27 MST by john.kimball
Modified: 2024-08-30 06:56 MST (History)
1 user (show)

See Also:
Impact Assessment: Light
Organization: DDC-I, Inc.
rroffelsen: Requirements-
rroffelsen: Code-
rroffelsen: TestCases?
rroffelsen: TestProcedures?
rroffelsen: Other?


Attachments

Note You need to log in before you can comment on or make changes to this PCR.
Description john.kimball 2015-09-03 05:27:04 MST
kernel_7.10.6 test procedures

- The following issues were identified in oversight reviews of
  chino and of the libraries/tools updated for it.
- Issues which have already been fixed in other PCRs (while the
  oversight review process occurred) have been removed (when
  spotted).
- Issues marked with a number -- "(N)" -- are likely
  enhancements/editorial.  Issues marked with a number and 't' --
  "(Nt)" -- are likely technical defects or checklist violations.
  Issues marked with a number and 'p' -- "(Np)" -- are likely process
  issues.


- File: /scm/products/kernel/kernel/branches/mainline/tests/code/x86/tpk510/tpk510b/tpk510b1.cpp
  - Issues identified in oversight review of packet tr281 in
    kernel_7.10.6 (extracted from ASPIRE)
  - URL: https://deos.ddci.com/scm/Deos/products/kernel/kernel/branches/mainline/tests/code/x86/tpk510/tpk510b/tpk510b1.cpp?r=29204  //o-review:23337
  - Function GPFaultError(), comment "the LMSW instruction is"
    - (1) "priviliged" should be "privileged"
  - Function PageFaultError(), comment on the "movl"
    - (2) "Refrence" should be "reference"
    - On line below, "refrence" should be "reference"
  - Function FloatingPointError(), comment on "fdiv"
    - (3) "currupting" should be "corrupting"
  - Function SystemCall()
    - Function header comment block missing

- File: /scm/products/kernel/kernel/branches/mainline/tests/code/ppc/tpk501/tpk501b/tpk501b1.cpp
  - Issues identified in oversight review of packet tr210 in
    kernel_7.10.6 (extracted from ASPIRE)
  - URL: https://deos.ddci.com/scm/Deos/products/kernel/kernel/branches/mainline/tests/code/ppc/tpk501/tpk501b/tpk501b1.cpp?r=26439  //o-review:23109
  - Function main(), in 'ifdef displayDebug' under createThread() call
    - (4) "Succesful" should be "Successful"
  - Function PrivInstException(), "Purpose:"
    - (5) "Priviledged" should be "privileged"
  - Function TrapException(), "Purpose:"
    - (6) "intruction" should be "instruction"
  - Function GeneralExceptionHandler(), comment "//First thing"
    - (7) "pervent castcading" should be "prevent cascading"
  - Function GeneralExceptionHandler(), comment "Ensure this exception handler touches", under "Note:"
    - (8) "incase" should be "in case"


- File: /scm/products/kernel/kernel/branches/mainline/tests/code/tpk455/tpk455_specializeIPal.cpp
  - Issues identified in oversight review of packet tr238 in
    kernel_7.10.6 (extracted from ASPIRE)
  - URL: https://deos.ddci.com/scm/Deos/products/kernel/kernel/branches/mainline/tests/code/tpk455/tpk455_specializeIPal.cpp?r=27100  //o-review:23238
  - In file header comments:
    - (9) Missing module name

- File: /scm/products/kernel/kernel/branches/mainline/tests/code/x86/tpk510/tpk510a/tpk510a1.cpp
  - Issues identified in oversight review of packet tr281 in
    kernel_7.10.6 (extracted from ASPIRE)
  - URL: https://deos.ddci.com/scm/Deos/products/kernel/kernel/branches/mainline/tests/code/x86/tpk510/tpk510a/tpk510a1.cpp?r=29232  //o-review:23337
  - Near top of tile, under "Test as many bits in the EFLAGS as possible", final two comments on code lines
    - In both comments, "becuase" should be "because"
  - Function GetGDTaddr()
    - (10) Header comment block for function missing (in contrast to
      earlier functions).
  - Function storeGDTSup()
    - (11) Header comment block for function missing (in contrast to
      earlier functions).
  - Function storeGDT()
    - (12) Header comment block for function missing (in contrast to
      earlier functions).
  - Function allocateIdentityMappedMemory()
    - (13) Header comment block for function missing (in contrast to
      earlier functions).
  - Function allocateIdentityMappedMemory(), in pTestIO->out of "unsufficent room to allocate"
    - (14) "insufficent" shoujld be "insufficient"
  - Function initTestGDT()
    - (15) Header comment block for function missing (in contrast to
      earlier functions).
  - Function testCase220() "Purpose:"
    - (16) "mechinism" should be "mechanism"
  - Function testCase220(), comments on assignment to EFLAGS_UserWriteableMask
    - (17) Last two comments on code lines, "becuase" should be
      "because"
  - Function testCase220(), near end
    - (18) Both "tout << Pass" lines: "befor" should be "before"

- File: /scm/products/kernel/kernel/branches/mainline/tests/code/tpk492/tpk492a/tpk492a1.cpp
  - Issues identified in oversight review of packet tr124 in
    kernel_7.10.6 (extracted from ASPIRE)
  - URL: https://deos.ddci.com/scm/Deos/products/kernel/kernel/branches/mainline/tests/code/tpk492/tpk492a/tpk492a1.cpp  //o-review:23086
  - At Top of file "Purpose:"
    - (19) "dependancies" should be "dependencies"
  - Function TestCase110(), header comment "Purpose"
    - (20) "willl" should be "will"

- File: /scm/products/kernel/kernel/branches/mainline/tests/code/ppc/tpk501/tpk501a/tpk501a1.cpp
  - Issues identified in oversight review of packet tr210 in
    kernel_7.10.6 (extracted from ASPIRE)
  - URL: https://deos.ddci.com/scm/Deos/products/kernel/kernel/branches/mainline/tests/code/ppc/tpk501/tpk501a/tpk501a1.cpp?r=17680  //o-review:23109
  - In Function ReadExcRegisters() "Purpose:"
    - (21) "ino" should be "into"
  - In Function TestFunction() "Purpose:"
    - (22) "excutes" should be "executes"

- File: /scm/products/kernel/kernel/branches/mainline/tests/code/ppc/tpk502/tpk502a/tpk502a1.cpp
  - Issues identified in oversight review of packet tr219 in
    kernel_7.10.6 (extracted from ASPIRE)
  - URL: https://deos.ddci.com/scm/Deos/products/kernel/kernel/branches/mainline/tests/code/ppc/tpk502/tpk502a/tpk502a1.cpp?r=26927  //o-review:23231
  - At Top of file, prototype for TestCase100()
    - (23) "fram" should be "frame"
  - At Top of file, prototype for TestCase110()
    - (24) "fram" should be "frame"
  - Function saveSegmentRegisters()
    - (25) Missing function header comments
  - Function saveSPRG7()
    - (26) Missing function header comments
  - Function Thread100Function() header comments
    - (27) "accessable" should be "accessible"
  - Function Thread100Function(), comment "check that the required user mode"
    - (28) "accessable" should be "accessible"
  - Function Thread100Function(), comment "check that the required supervisor mode"
    - (29) "accessable" should be "accessible"
  - Function TestCase110(), comment "Note: The clobber register lists"
    - (30) "incase" should be "in case"

- File: /scm/products/kernel/kernel/branches/mainline/tests/code/tpk230/tpk230a/tpk230a1.cpp
  - Issues identified in oversight review of packet tr96 in
    kernel_7.10.6 (extracted from ASPIRE)
  - URL: https://deos.ddci.com/scm/Deos/products/kernel/kernel/branches/mainline/tests/code/tpk230/tpk230a/tpk230a1.cpp  //o-review:22972
  - At Top of file "Purpose:"
    - (31) suggest add this table to the tck230 comments or here, so
      the procA, B, C, D registry info and purpose are more clear
     |       | inDebugSet | breakAtStartup | exceptions     |
     | ProcA | no         | no             | n/a            |
     | ProcB | yes        | no             | Illegal access |
     | ProcC | no         | yes            | Divide by 0    |
     | ProcD | yes        | yes            | n/a            |
  - Function workerEntryPoint(), case 160, comment
    - (32) suggest add comment that causes processorSpecificEx
  - Function workerEntryPoint(), case 180
    - (33) There is no SRS in tck230 to support this test. But in the
      ddd.htm, at 8.14.2.2 Warning/Retrictions it is mentioned. So
      suggest : modify tck230
  - Function workerEntryPoint(), case 190
    - (34) There is no SRS in tck230 to support this test. But in the
      ddd.htm, at 8.14.2.2 Warning/Retrictions it is mentioned. So
      suggest : modify tck230


- File: /scm/products/kernel/kernel/branches/mainline/tests/code/tpk455/tpk455a/tpk455a1.cpp
  - Issues identified in oversight review of packet tr238 in
    kernel_7.10.6 (extracted from ASPIRE)
  - URL: https://deos.ddci.com/scm/Deos/products/kernel/kernel/branches/mainline/tests/code/tpk455/tpk455a/tpk455a1.cpp?r=27100  //o-review:23238
  - Function TestCase130(), under "First, did the kernelModeError function get called?", the "if" statement
    - (35t) The logic here should be: if ((results->errorCode ==
      NO_KERNEL_MODE_ERROR) or (results->data1 ==
      NO_KERNEL_MODE_ERROR) or (results->data2 ==
      NO_KERNEL_MODE_ERROR)) due to tpk455_specializeIPal_27100.cpp
      line 262-270 set the error codes. If the error handler get
      called, it is the failed test.
  - Function TestCase150(), under "First, did the kernelModeError function get called?", the "if" statement
    - (36t) The logic here should be: if ((results->errorCode ==
      NO_KERNEL_MODE_ERROR) or (results->data1 ==
      NO_KERNEL_MODE_ERROR) or (results->data2 ==
      NO_KERNEL_MODE_ERROR)) due to tpk455_specializeIPal_27100.cpp
      line 262-270 set the error codes. If the error handler get
      called, it is the failed test.
Comment 1 deosbugs.ccb 2015-09-03 13:02:23 MST
CCB 2 visited this PCR on 2015-09-03.
Comment 2 deosbugs.ccb 2015-09-17 13:09:54 MST
CCB visited this PCR on 2015-09-17.
Comment 3 deosbugs.ccb 2016-06-20 13:11:01 MST
CCB visited this PCR on 2016-06-20
Comment 4 deosbugs.ccb 2016-07-13 10:34:30 MST
CCB visited this PCR on 2016-07-13
Comment 5 deosbugs.admin 2016-10-20 09:05:18 MST
CCB visited this PCR on 2016-10-20-54604
Comment 6 deosbugs.ccb 2017-02-01 09:36:41 MST
CCB visited this PCR on 2017-02-01-59501
Comment 7 deosbugs.ccb 2017-04-18 09:52:55 MST
CCB visited this PCR on 2017-04-18-59571
Comment 8 deosbugs.ccb 2017-04-21 08:56:42 MST
CCB visited this PCR on 2017-04-21-54338
Comment 9 deosbugs.ccb 2017-05-18 13:12:15 MST
CCB visited this PCR on 2017-05-18-71846
Comment 10 deosbugs.ccb 2017-05-18 13:25:19 MST
This will not be addressed for kernel 8.4.2.
Comment 11 deosbugs.ccb 2017-06-28 12:59:57 MST
CCB visited this PCR on 2017-06-28-69227
Comment 12 deosbugs.ccb 2021-03-26 09:34:38 MST
CCB visited this PCR on 2021-03-26-57787
Comment 13 deosbugs.ccb 2021-04-05 09:52:01 MST
CCB visited this PCR on 2021-04-05-59141
Comment 14 deosbugs.ccb 2023-08-14 11:05:09 MST
CCB visited this PCR on 2023-08-14-64795
Comment 15 deosbugs.ccb 2023-08-18 08:35:35 MST
PCR being taken off HOLD for kismet.
Comment 16 deosbugs.ccb 2024-04-04 13:19:46 MST
CCB visited this PCR on 2024-04-04-71881
Comment 17 deosbugs.ccb 2024-08-30 06:56:01 MST
CCB visited this PCR on 2024-08-30-49739