PCR 10883 - Test: commonCode.cpp does not compile for x86 PE images (tpk242)
Summary: Test: commonCode.cpp does not compile for x86 PE images (tpk242)
Status: NEW
Alias: None
Product: Kernel
Classification: Deos
Component: Kernel (show other PCRs)
Version: mainline
Hardware: X86 Deos
: Hold
: Enhancement
Target Milestone: mainline
Assignee: .Kernel
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2017-04-21 10:17 MST by gkindorf
Modified: 2024-12-04 15:41 MST (History)
0 users

See Also:
Impact Assessment: Trivial
Organization: DDC-I, Inc.
gkindorf: Requirements-
gkindorf: Code-
gkindorf: TestCases-


Attachments

Note You need to log in before you can comment on or make changes to this PCR.
Description gkindorf 2017-04-21 10:17:28 MST
When building the tests for x86, (at least) tpk242 will not compile due to a construct in commonCode.cpp MemoryPoolConfiguration::sizeofPlatformMemoryPool().

Aaron suggested the below as the basis for a solution.

  UNSIGNED32 numRanges = getNumMemoryRanges(poolIndex);
  // The GCC 4.6.1 PE compiler generates a call to __chkstk_ms for runtime
  // computed array bounds, and our PE runtime doesn't define that symbol, so we
  // pick a decently large size and generate a runtime failure if we're wrong.
  //  UNSIGNED32 effectiveSizeOfRanges[numRanges];
  while (numRanges > 30) continue;
  UNSIGNED32 effectiveSizeOfRanges[30];

This PCR is initially placed on HOLD for the 8.4.2 verification cycle.
Comment 1 deosbugs.ccb 2017-06-28 13:01:03 MST
CCB visited this PCR on 2017-06-28-69227
Comment 2 deosbugs.ccb 2017-07-06 11:07:01 MST
CCB visited this PCR on 2017-07-06-58325
Comment 3 deosbugs.ccb 2021-03-26 09:36:14 MST
CCB visited this PCR on 2021-03-26-57787
Comment 4 deosbugs.ccb 2021-04-05 09:53:29 MST
CCB visited this PCR on 2021-04-05-59141
Comment 5 deosbugs.ccb 2023-08-14 11:06:08 MST
CCB visited this PCR on 2023-08-14-64795
Comment 6 deosbugs.ccb 2024-04-04 14:26:15 MST
CCB visited this PCR on 2024-04-04-71881
Comment 7 deosbugs.ccb 2024-04-04 14:45:11 MST
PCR to remain on HOLD for kismet verf, since support for x86 PE is not planned for Kismet.
Comment 8 deosbugs.ccb 2024-12-04 15:41:56 MST
CCB visited this PCR on 2024-12-04-74123