PCR 15845 - Move headerIntegrityKey in BootImageFileHeader_t
Summary: Move headerIntegrityKey in BootImageFileHeader_t
Status: NEW
Alias: None
Product: Kernel
Classification: Deos
Component: Kernel (show other PCRs)
Version: experimental
Hardware: All Deos
: Hold
: Enhancement
Target Milestone: mainline
Assignee: .Kernel
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2024-08-05 14:02 MST by rroffelsen
Modified: 2024-12-11 13:40 MST (History)
1 user (show)

See Also:
Impact Assessment: TBD
Organization: DDC-I, Inc.
rroffelsen: Requirements-
rroffelsen: Code? (sdicaro)
rroffelsen: TestCases-
rroffelsen: TestProcedures-
rroffelsen: Other?


Attachments
Patch with fix for moving headerIntegrityKey to end of BIFH. (5.88 KB, patch)
2024-08-23 15:27 MST, Sam DiCaro
Details
Patch with fix for moving headerIntegrityKey to end of BIFH. (5.88 KB, patch)
2024-08-23 15:34 MST, Sam DiCaro
Details

Note You need to log in before you can comment on or make changes to this PCR.
Description rroffelsen 2024-08-05 14:02:28 MST
Relocate headerIntegrityKey to the end of BootImageFileHeader_t and don't include it as 0 int the integrity key computation.
Comment 1 Sam DiCaro 2024-08-20 15:16:39 MST
Committed SVNRevision 94949.

- Moved headerIntegrityKey to the end of the BootImageFileHeader_t struct.
- Adjusted any header integrity key calculation to no longer include the headerIntegrityKey.
  - Includes calculations for bif and mfs.
  - No longer need multiple crc calculations for mfs header integrity key.
Comment 2 Sam DiCaro 2024-08-23 15:24:19 MST
Committed SVNRevision 95005.

Revert changes from previous commit, r94949. Waiting on BSP team for go-ahead to continue work.
Comment 3 Sam DiCaro 2024-08-23 15:27:15 MST
Created attachment 4774 [details]
Patch with fix for moving headerIntegrityKey to end of BIFH.

Implement when given the BSP Team is ready for the change.
Comment 4 Sam DiCaro 2024-08-23 15:34:51 MST
Created attachment 4775 [details]
Patch with fix for moving headerIntegrityKey to end of BIFH.

Implement when given the BSP Team is ready for the change.
Comment 5 deosbugs.ccb 2024-08-30 06:57:12 MST
CCB visited this PCR on 2024-08-30-49739
Comment 6 deosbugs.ccb 2024-08-30 09:13:28 MST
Developer asserts updates are acceptable for 11.4.0.
Comment 7 Sam DiCaro 2024-10-16 10:15:08 MST
Committed SVNRevision 95825.

Applying patch from attachment 4775 [details] in Bugzilla. BSP Team is ready for changes.
Comment 8 Sam DiCaro 2024-10-29 14:57:13 MST
Committed SVNRevision 95964.

Reverted applied patch from attachment 4775 [details]. BSP Team decided BIFH changes will be done post kismet.
Comment 9 deosbugs.ccb 2024-12-11 13:05:04 MST
CCB visited this PCR on 2024-12-11-68907
Comment 10 deosbugs.ccb 2024-12-11 13:40:04 MST
Developer asserts all updates have been undone, and this feature is not being implemented on Kismet.  PCR being placed on HOLD.