The following scenario is not handled in the following SAL API:

SALBASEAPI int SALAPI sendto(int s, PFCCHAR buf, int len, int flags, PCSOCKADDR to, int tolen)
 

When calling sendto with to=NULL, and tolen=non-zero, the to and the tolen fields in the dataMessageType structure are not initialized.

 
Existing code:
if (to)
  {
    dataMessage->op.sendto.to = *to;
    dataMessage->op.sendto.tolen = tolen;
  }
 


The above code assumes that the envelope the dataMessage is being copied into has been cleared, which is not the case.

There is a missing else clause:

else

    {

            memset(dataMessage->op.sendto.to, 0,  sizeof(dataMessage->op.sendto.to));

            dataMessage->op.sendto.tolen = 0;

    }

With the added else clause, if I don’t pass in a 'to', the 'tolen' field is initialized correctly to 0.  If this is not done, when I pass a null 'to' into the function, the 'to' and 'tolen' are not defined.