PCR 9430 - Test tpk304 and tpk504: library function getPalInterruptHandlerPtr() unnecessary.
Summary: Test tpk304 and tpk504: library function getPalInterruptHandlerPtr() unnecess...
Status: ASSIGNED
Alias: None
Product: Kernel
Classification: Deos
Component: Kernel (show other PCRs)
Version: mainline
Hardware: All Deos
: By Cert
: Enhancement
Target Milestone: mainline
Assignee: .Kernel
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2014-09-04 10:02 MST by alarson
Modified: 2024-08-30 06:57 MST (History)
1 user (show)

See Also:
Impact Assessment: Light
Organization: DDC-I, Inc.
alarson: Requirements-
deosbugs.ccb: Code-
deosbugs.ccb: TestCases?
deosbugs.ccb: TestProcedures?
deosbugs.ccb: Other-

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this PCR.
Description alarson 2014-09-04 10:02:59 MST 
The kernel tests tpk304 and 504 use the getPalInterruptHandlerPtr() function to get the original PAL interrupt handler.  The PAL interrupt handler can be gotten by instead intercepting the setInterruptHandler() kernel function.  At present, the tpk304 and tpk504 tests, and the getPalInterruptHandlerPtr() function use a variety of type casts that inhibit the compiler from doing proper type checking on the function pointer type.  Also, if the tests stop using getPalInterruptHandlerPtr(), then the kernel can stop returning that data from getArchSpecTestInfo().
Comment 1 deosbugs.ccb 2014-09-04 13:00:54 MST 
CCB visited this PCR on 2014-09-04.
Comment 2 deosbugs.ccb 2014-09-25 13:05:28 MST 
CCB visited this PCR on 2014-09-25.
Comment 3 deosbugs.ccb 2014-11-11 13:18:47 MST 
CCB 2 visited this PCR on 2014-11-11
Comment 4 deosbugs.ccb 2014-11-17 09:00:11 MST 
CCB visited this PCR on 2014-11-17
Comment 5 deosbugs.ccb 2016-04-18 12:57:34 MST 
CCB visited this PCR on 2016-04-18
Comment 6 deosbugs.ccb 2016-06-20 13:10:35 MST 
CCB visited this PCR on 2016-06-20
Comment 7 deosbugs.ccb 2017-02-01 09:42:47 MST 
CCB visited this PCR on 2017-02-01-59501
Comment 8 deosbugs.ccb 2017-04-18 09:53:45 MST 
CCB visited this PCR on 2017-04-18-59571
Comment 9 deosbugs.ccb 2017-04-21 08:56:17 MST 
CCB visited this PCR on 2017-04-21-54338
Comment 10 deosbugs.ccb 2017-05-18 13:11:44 MST 
CCB visited this PCR on 2017-05-18-71846
Comment 11 deosbugs.ccb 2017-05-18 13:24:54 MST 
This will not be addressed for kernel 8.4.2.
Comment 12 deosbugs.ccb 2017-06-28 13:01:27 MST 
CCB visited this PCR on 2017-06-28-69227
Comment 13 deosbugs.ccb 2017-07-06 11:07:27 MST 
CCB visited this PCR on 2017-07-06-58325
Comment 14 deosbugs.ccb 2021-03-26 09:36:51 MST 
CCB visited this PCR on 2021-03-26-57787
Comment 15 deosbugs.ccb 2021-04-05 09:53:57 MST 
CCB visited this PCR on 2021-04-05-59141
Comment 16 deosbugs.ccb 2021-04-05 10:09:57 MST 
This will not be addressed for kernel 9.2.3, so is being placed on HOLD.
Comment 17 deosbugs.ccb 2021-04-14 05:26:25 MST 
CCB visited this PCR on 2021-04-14-44714
Comment 18 deosbugs.ccb 2021-04-29 08:47:21 MST 
CCB visited this PCR on 2021-04-29-55421
Comment 19 deosbugs.admin 2021-06-21 12:24:03 MST 
CCB visited this PCR on 2021-06-21-69616
Comment 20 deosbugs.ccb 2021-08-18 08:32:48 MST 
CCB visited this PCR on 2021-08-18-52487
Comment 21 deosbugs.ccb 2021-10-25 13:33:50 MST 
CCB visited this PCR on 2021-10-25-57687
Comment 22 gkindorf 2022-03-15 12:37:51 MST 
This PCR has been deferred for a few verification cycles, and at this point in history, TPKs 299, 300, 304, 504, and 425 are all using getPalInterruptHandlerPtr().  Although I understand how the tests could be modified to not use getPalInterruptHandlerPtr via a setInterruptHandler interceptor, I am not sure if tpk304 (which is the test for setInterruptHandler requirements) should intercept the API under test (philosophically).
Comment 23 alarson 2022-03-21 07:56:42 MST 
(In reply to gkindorf from comment #22)

> ... I am not sure if tpk304 (which is the test for
> setInterruptHandler requirements) should intercept the API under
> test (philosophically).

Intercepting the PPI under test seems like a perfectly fine way to
test the kernel's behavior.

As to the point of the PCR, if the test team finds it easier to use getPalInterruptHandlerPtr() than an interceptor, it is fine to just reject this PCR.
Comment 24 deosbugs.ccb 2022-08-16 14:50:12 MST 
CCB visited this PCR on 2022-08-16-75836
Adding string again because CCB admin was impatient, and not all PCRs got the string on the first try.
Comment 25 gkindorf 2022-11-22 17:14:27 MST 
This PCR should be put on HOLD for jupiter.
Comment 26 deosbugs.ccb 2023-02-13 13:06:58 MST 
CCB visited this PCR on 2023-02-13-71816
Comment 27 deosbugs.ccb 2023-02-13 13:08:29 MST 
Per developer's recommendation, PCR being placed on HOLD.  It will be considered for a subsequent verf.
Comment 28 deosbugs.ccb 2023-08-14 11:06:28 MST 
CCB visited this PCR on 2023-08-14-64795
Comment 29 deosbugs.ccb 2024-04-04 14:26:26 MST 
CCB visited this PCR on 2024-04-04-71881
Comment 30 deosbugs.ccb 2024-04-04 14:33:32 MST 
PCR being taken off HOLD for Kismet verf.  Test Team lead to determine if PCR is valid or should be rejected.
Comment 31 deosbugs.ccb 2024-08-30 06:57:04 MST 
CCB visited this PCR on 2024-08-30-49739